search

pinojs / pino-tee

🌲 tee pino logs into a file, with multiple levels
MIT License
89 stars 17 forks source link

fix tests by locking cloneable readable to patches only #9

Closed davidmarkclements closed 6 years ago

davidmarkclements commented 6 years ago

cloneable-readable v1.1.0+ breaks https://github.com/pinojs/pino-tee/blob/master/test/api.js#L42-L79

specifically, https://github.com/pinojs/pino-tee/blob/master/test/api.js#L66 occurs too late for cloneable-readable to hold onto the data in the pipeline so https://github.com/pinojs/pino-tee/blob/master/test/api.js#L71 is never fired and the test never finishes.

This fixes the behaviour and tests, I found this bug using the new http://github.com/pinojs/pino-integration CI runner – this is the final thing to fix before we are sure that all tests pass in current ecosystem modules and on pino master

image

mcollina commented 6 years ago

i do not think this is a correct fix. That bug on cloneable-readable was real, so it’s a bug in this one that need fixing.

Il giorno mer 20 giu 2018 alle 16:08 David Mark Clements < notifications@github.com> ha scritto:

Merged #9 https://github.com/pinojs/pino-tee/pull/9.

— You are receiving this because your review was requested.

Reply to this email directly, view it on GitHub https://github.com/pinojs/pino-tee/pull/9#event-1691587035, or mute the thread https://github.com/notifications/unsubscribe-auth/AADL4-q9QGHcPhwV-85h-pjPfwMHcjE5ks5t-nOIgaJpZM4UvHh2 .

davidmarkclements commented 6 years ago

@mcollina https://github.com/pinojs/pino-tee/issues/10