search

pinojs / quick-format-unescaped

Solves a problem with util.format
MIT License
17 stars 13 forks source link

Fix escaping #14

Closed yaroslav-korotaev closed 6 years ago

yaroslav-korotaev commented 6 years ago

Resolves #13

mcollina commented 6 years ago

Can you add a unit test?

davidmarkclements commented 6 years ago

thanks for this!

would you mind adding before/after benchmark output?

yaroslav-korotaev commented 6 years ago

+-20ms

before:
util*100000: 318.775ms
quickLowres*100000: 372.406ms
quick*100000: 424.844ms
utilWithTailObj*100000: 619.407ms
quickWithTailObjLowres*100000: 409.077ms
quickWithTailObj*100000: 461.625ms
util*100000: 310.034ms
quickLowres*100000: 365.254ms
quick*100000: 410.380ms
utilWithTailObj*100000: 511.166ms
quickWithTailObjLowres*100000: 382.802ms
quickWithTailObj*100000: 440.928ms

after:
util*100000: 303.136ms
quickLowres*100000: 307.512ms
quick*100000: 355.228ms
utilWithTailObj*100000: 599.588ms
quickWithTailObjLowres*100000: 350.440ms
quickWithTailObj*100000: 404.619ms
util*100000: 297.329ms
quickLowres*100000: 297.532ms
quick*100000: 345.720ms
utilWithTailObj*100000: 489.627ms
quickWithTailObjLowres*100000: 324.175ms
quickWithTailObj*100000: 390.236ms
davidmarkclements commented 6 years ago

thank you @yaroslav-korotaev