search

pinojs / quick-format-unescaped

Solves a problem with util.format
MIT License
17 stars 13 forks source link

Fix json formatting #29

Closed jsumners closed 4 years ago

jsumners commented 4 years ago

😞 I broke it in #27

This PR:

  1. Fixes format('some-prefix-string %j', [{foo: 'foo'}]) leaving off "some-prefix-string " when formatting.
  2. Covers all lines of code and all branches in the testing so that this doesn't happen again.

@davidmarkclements let's get this published so that v4 isn't broken

jsumners commented 4 years ago

Let's also merge #28 before this one so that Travis will shut up about Node 6.

davidmarkclements commented 4 years ago

ci failing for 6 - doesn't matter