search

pinojs / sonic-boom

Extremely fast utf8 only stream implementation
MIT License
261 stars 41 forks source link

fix: max write buffering #126

Closed ronag closed 2 years ago

ronag commented 2 years ago

The current logic looks wrong. I don't know exactly what kind of behaviour it would cause but I believe this version is more correct.

ronag commented 2 years ago

I'm not sure what the failing test is testing. Doesn't quite make sense to me? Maybe someone could clarify?

mcollina commented 2 years ago

I'm not sure what the failing test is testing. Doesn't quite make sense to me? Maybe someone could clarify?

what test? seems CI is passing.

ronag commented 2 years ago

I'm not sure what the failing test is testing. Doesn't quite make sense to me? Maybe someone could clarify?

what test? seems CI is passing.

My mistake. Missed resetting a file when testing.