search

pinojs / sonic-boom

Extremely fast utf8 only stream implementation
MIT License
266 stars 41 forks source link

Lower MAX_WRITE to 64KB #128

Closed mcollina closed 2 years ago

mcollina commented 2 years ago

This seems a good idea to do given how the current mechanism work in v2.

mcollina commented 2 years ago

@ronag could you verify if it fixes your problems?

ronag commented 2 years ago

@ronag could you verify if it fixes your problems?

Little difficult. Takes a lot of effort so I'd like to understand why you think this would help?

mcollina commented 2 years ago

A comment in the other issue showed a truncation really close to 64KB. Therefore there might be some bad interaction there. It also seems a safer number.

ronag commented 2 years ago

It's easier if you make a release. Any reason to not do this?

ronag commented 2 years ago

Deployed to production. I'll keep you posted.

ronag commented 2 years ago

Still a problem.

mcollina commented 2 years ago

I really need a repro.

ronag commented 2 years ago

Yea, I get that. We are trying.

ronag commented 2 years ago

@mcollina Could we make some kind of debug version which could provide us with more info? I don't know exactly what that would mean in practice though. I think we can run a low perf version of sonic-boom in production.