search

pinojs / sonic-boom

Extremely fast utf8 only stream implementation
MIT License
261 stars 41 forks source link

Don't add test and development files to package #167

Closed jorrit closed 1 year ago

jorrit commented 1 year ago

This PR removes development files and test files from the NPM package.

If it is preferred to keep the test files, I'll update the PR.

Fdawgs commented 1 year ago

Thanks for the PR. See https://github.com/fastify/skeleton/issues/42 for both Fastify and Pino's stance on why these are included.

jorrit commented 1 year ago

The issue you've linked to gives an argument why having an .npmignore file at all is a bad idea. It does not give an argument why having development files in the NPM package is a good idea. Considering that sonic-boom already has an .npmignore file, I don't see how the argument applies. Anyway, you are the maintainer, you decide.