search

pinojs / sonic-boom

Extremely fast utf8 only stream implementation
MIT License
266 stars 41 forks source link

Always emit drain after flush() #180

Open mcollina opened 1 year ago

mcollina commented 1 year ago

This can unfortunately lead to pino to not call end() on the stream.

https://github.com/pinojs/pino/blob/28819c3a6324f8d26e7653cf08b35156bf9318d2/lib/tools.js#L274-L276

mcollina commented 1 year ago

I'm currently trying to debug some flaky tests downstream. This was something I saw happening and might be correlated.