search

pinojs / sonic-boom

Extremely fast utf8 only stream implementation
MIT License
266 stars 41 forks source link

What Changes are Breaking for v1 -> v2? #88

Closed aphix closed 3 years ago

aphix commented 3 years ago

Forgive me if I just missed it, but in looking to update some deps I see that this has been bumped to v2+ and I don't see the breaking changes listed anywhere, so figured I'd create an issue to ask what they may be (and to perhaps get them documented).

Cheers, and thanks for the great module.

kibertoad commented 3 years ago

https://github.com/pinojs/sonic-boom/pull/66 and https://github.com/pinojs/sonic-boom/pull/45 (note that TS types are not compatible with DT ones).

aphix commented 3 years ago

Assuming I'm already on Node v12 and up, is there any functional/usage difference that would result from the flatstr removal?

Thanks for the quick reply!

kibertoad commented 3 years ago

@aphix The only difference is that your performance might improve. See https://github.com/davidmarkclements/flatstr/issues/10

aphix commented 3 years ago

@kibertoad So, no changes from me and a potential performance boost? Awesome! That's a rare and nice thing to hear =)

Thanks again, closing-