pinojs / thread-stream

A streaming way to send data to a Node.js Worker Thread
MIT License
229 stars 23 forks source link

Fix yarn build. #111

Closed ShogunPanda closed 1 year ago

ShogunPanda commented 1 year ago

Fixes #110.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 3938524242


Totals Coverage Status
Change from base Build 3894546184: 0.0%
Covered Lines: 182
Relevant Lines: 356

💛 - Coveralls
ShogunPanda commented 1 year ago

@mcollina I fixed the original problem but now I have a failure which I'm not sure is related to yarn. Do you have any hint?

Update: I tried to reproduce on both my Mac and Linux box, no luck. I leave this to you.

mcollina commented 1 year ago

What is

/home/runner/work/thread-stream/thread-stream/.yarn/cache/stackback-npm-0.0.2-73273dc92e-2d4dc4e64e.zip/node_modules/stackback/index.js:25
        Object.defineProperty(err, '_sb_callsites', {
               ^

TypeError: Cannot redefine property: _sb_callsites
(Use `node --trace-uncaught ...` to show where the exception was thrown)

About?

ShogunPanda commented 1 year ago

From what I've discovered, stackback is a package lastly released 10 years go (not a typo) and used by why-is-node-running in the tests.

Why is failing in yarn is a mastery to me.

mcollina commented 1 year ago

I have no clue on how to fix this. Maybe we could avoid to require why-is-node-running if running the test after installing via yarn pnp?

ShogunPanda commented 1 year ago

I agree. Especially since having a 10 years package in the test suite makes me a little nervous.

mcollina commented 1 year ago

Could you add that change?

ShogunPanda commented 1 year ago

Sure, I will tomorrow!

mcollina commented 1 year ago

amazing work! Thanks!

ShogunPanda commented 1 year ago

You're welcome my friend. It has been an exhausting and horrible journey. :)