coveralls
commented
2 years ago Pull Request Test Coverage Report for Build 2013234290
- -1 of 5 (80.0%) changed or added relevant lines in 1 file are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage decreased (-1.007%) to 83.51%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| index.js | 4 | 5 | 80.0% | ||
| <!-- | Total: | 4 | 5 | 80.0% | --> |
| Totals | |
|---|---|
| Change from base Build 1944840406: | -1.007% |
| Covered Lines: | 290 |
| Relevant Lines: | 335 |
Flush could error both synchronously and asynchronously, making it extremely hard to handle both cases. In case of a race condition it could even make the error uncatchable.
My understanding is this should fix https://github.com/pinojs/pino/issues/1375. However this is yet to be seen. It definitely fixes some flakiness in our CI.