search

pinpoint-apm / pinpoint-c-agent

Pinpoint C Agent helps your monitor your PHP/PYTHON applications into [pinpoint-apm](https://github.com/pinpoint-apm/pinpoint).
http://pinpoint-apm.github.io/pinpoint/
Apache License 2.0
262 stars 78 forks source link

This is cxx extension #655

Closed remicollet closed 3 months ago

remicollet commented 3 months ago

Fix PHP_NEW_EXTENSION to use C++ linker, so there is no need to addlibstdc++ which is present by default with cxx command.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.63%. Comparing base (5187cc0) to head (0adff49). Report is 12 commits behind head on dev.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #655 +/- ## ========================================== - Coverage 80.79% 80.63% -0.16% ========================================== Files 22 22 Lines 1536 1539 +3 Branches 165 166 +1 ========================================== Hits 1241 1241 - Misses 162 164 +2 - Partials 133 134 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

eeliu commented 3 months ago

@remicollet Can you resolve this conflicts ?

remicollet commented 3 months ago

Rebased

remicollet commented 3 months ago

Notice: without this change, the build will be broken on RHEL and clones when using alternative GCC versions (gcc-toolset) which may need additional static libraries only added when invoked as cxx (so libstdc++ is not enough)