PHP: bad License in package.xml

[remicollet]

package.xml states

<license uri="http://www.php.net/license">PHP</license>

LICENSE file is "Apache-2.0"

Please fix package.xml for consistency

[remicollet]

Notice: it will be nice to have the package.xml file stored in git repository so we can open PR for it

Also nice a have changelog inside the package.xml so useful information will be found at https://pecl.php.net/package-changelog.php?package=pinpoint_php

[eeliu]

@remicollet

Got it, I will change them.

[eeliu]

@remicollet

Can you help me , how to upload windows .dll into pecl.php.net ?

https://github.com/eeliu/pinpoint-c-agent/actions/runs/10141196543#artifacts

For pecl, only a upload button for these files

But I want to release these .dll as redis

[remicollet]

Can you help me , how to upload windows .dll into pecl.php.net ?

Sorry, no, I don't know anything about Windows

Perhaps @cmb69 may help

[eeliu]

@remicollet

Thanks all the same

[cmb69]

See https://news-web.php.net/php.pecl.dev/17597.

[eeliu]

@cmb69 Thanks

But my problems is how to upload these compiled binary package into pecl.php.net like phpredis dll.

I already got an account.

[cmb69]

But my problems is how to upload these compiled binary package into pecl.php.net like phpredis dll.

You are not supposed to do this. Instead, make that package buildable on Windows first. While there is a config.m4, there is no config.w32, which is a first requirement to build the extension on Windows.

[cmb69]

Ah, I've just noticed that there is a config.w32 in the PECL package (but apparently that is missing from this repo), and did a quick test build without any issues. Therefore I requested https://github.com/php/php-windows-builder/issues/3#issuecomment-2260279730, so that the DLLs can be built, and uploaded.

[cmb69]

The DLLs are available now, thanks to @shivammathur.

[eeliu]

@cmb69 @smalltangcai @remicollet

Thanks your help !

I have another question: can those .dll be uploaded automatically, what should I do when create a new release ?

[shivammathur]

@eeliu We are doing PECL builds for Windows currently, so when you add a new release, the DLLs will be added. Feel free to reach out if there is a delay.

[eeliu]

it looks ok to close

thanks again