search

pinpoint-apm / pinpoint-docker

Official Dockerized components of the Pinpoint
http://pinpoint-apm.github.io/pinpoint/
Apache License 2.0
461 stars 227 forks source link

Can we run Pinpoint Agent as a daemonset or sidecar across the deployment in any contain ecosystem? #34

Open dinesh4747 opened 4 years ago

dinesh4747 commented 4 years ago

Context:

In my Kubernetes infrastructure, there were 100 of Apps (90% of Spring boot apps + 10% of Node JS App) running on GCP(GKE) Environment.

Questions:

Can i run pinpoint agent as below, I am aware of that Pinpoint agent does byte code instrumentation and it runs along with app container, However just curious to understand which one would be the "Best way to induce/integrate Pinpoint Agent in Spring boot appl running as a container"

1) Is it right methodology to run Pinpoint java agent as a daemonset

2) How about running as a side-car container along with spring boot app container along side?

3) As a default option to run a docker-compose file to run spring boot+Pinpoint Agent as a single container deployment ?

These all are assumptions, Hence please do correct me If I have misinterpreted anything here

emeroad commented 4 years ago
  1. Is it right methodology to run Pinpoint java agent as a daemonset
    • I'm not sure what "demonset" means. The pinpoint-agent runs inside the application.
  2. How about running as a side-car container along with spring boot app container along side?
    • We are preparing an ISTIO module for the sidecar. The sidecar pattern has a limitation that it cannot be tracked inside the application.
  3. As a default option to run a docker-compose file to run spring boot+Pinpoint Agent as a single container deployment ?
    • Of course you have to run with single container. Because the agent does not run as another process.
dinesh4747 commented 4 years ago

@emeroad - Thanks for the valuable insights, it really helps, Just one more question like all my apps sitting as a container (pods) on GKE environment whereas all the traffic goes through Istio via gRPC , My question here is whether current version of pinpoint supports that ?

RoySRose commented 4 years ago

Hello, @dinesh4747, again.

I see a few questions that were already answered on gitter.

just to supplement a few things. As answered through gitter. Istio will be supported in the future releases. So of course, currently Pinpoint doesn't support it.

Is the application and Pinpoint Agent running inside a single container? Yes. Does it HAVE to be deployed as a single container? I think not You can take a look at our docker repository

I believe you will find the difference.