search

pinpoint-apm / pinpoint-kubernetes

Apache License 2.0
26 stars 37 forks source link

Add Mysql dependency #3

Closed seongpyoHong closed 4 years ago

seongpyoHong commented 4 years ago

Changes

RoySRose commented 4 years ago

I've check few configurations in the stable sql image.

I think we don't have to use the docker image in pinpoint-mysql.

We can even initialize with the configs here https://hub.helm.sh/charts/stable/mysql

what do you think?

RoySRose commented 4 years ago

Since helm hub is migrating to artifact hub. we can just use the chart from https://artifacthub.io/packages/helm/helm-stable/mysql and add configurations for initializing the tables.

Let me hear your thoughts

seongpyoHong commented 4 years ago

I agree to use the configuration for initial table creation without using the pinpoint-mysql image.

The Helm hub you mentioned is a collection of repositories and charts for search, and the part we use to establish dependencies is the repository. Therefore, it seems that we need to discuss the repository regardless of the migration from the helm hub to the artifact hub.

From what I've looked for, Helm will stop the maintenance of the existing stable repository and the future chart will be carried out by the owner of each repository on the Helm Hub.

Of course, we will be able to use the stable chart, but we cannot expect more updates. Therefore we will have to use the repository maintained by other organizations other than the stand chart. ex) https://github.com/bitnami/charts

RoySRose commented 4 years ago

@seongpyoHong I've tested the installation. But couldn't do functional tests since there aren't any other components yet.

However, PR is merged. We can take care of any other bugs before the initial release.