search

pinpoint-apm / pinpoint-kubernetes

Apache License 2.0
25 stars 38 forks source link

add pinpoint-collector #4

Open JacksChoco opened 3 years ago

JacksChoco commented 3 years ago
RoySRose commented 3 years ago

Please resolve the conflict with the latest master branch.

Is 9080 port just for liveness check?

RoySRose commented 3 years ago
  1. Is port 9080 only for checking liveness?

  2. There was a cleanup on environment variables in the docker image of v2.1.0 Pinpoint. You can see the list under pinpoint-collector in the docker-compose file (https://github.com/naver/pinpoint-docker/blob/master/docker-compose.yml). The differences I found so far are below

    • externalZookeeperAddress can be renamed to something like pinpoint zookeeper address
    • externalHbaseAddress is not necessary
    • I can see Values.externalZookeeperAddress in the values.yaml but where is Values.flink.zookeeperAddress? flink zookeeper address is necessary
    • I don't think Hbase_port is also necessary.

(I think there were a few more things. But can't remember after my former reply was mistakenly deleted. I'll update as soon as I remember)