search

pinpoint-apm / pinpoint-plugin-sample

Pinpoint(https://github.com/naver/pinpoint) profiler plugin sample
69 stars 41 forks source link

Sample 2 won't work as expected. #35

Open jejayhe opened 3 years ago

jejayhe commented 3 years ago

https://github.com/pinpoint-apm/pinpoint-plugin-sample/blob/master/plugin/src/main/java/com/navercorp/pinpoint/plugin/sample/_02_Injecting_Custom_Interceptor/RecordArgsAndReturnValueInterceptor.java line110 wouldn't show arg0 in pinpoint-web since https://github.com/pinpoint-apm/pinpoint-plugin-sample/blob/master/plugin/src/main/resources/META-INF/pinpoint/type-provider.yml line5 it only matches code 998. Do I understand that right?

jaehong-kim commented 3 years ago

@jejayhe Modified the sample.

https://github.com/pinpoint-apm/pinpoint-plugin-sample/blob/master/plugins/sample/src/main/java/com/navercorp/pinpoint/plugin/sample/_02_Injecting_Custom_Interceptor/RecordArgsAndReturnValueInterceptor.java

recorder.recordApi(descriptor);
recorder.recordAttribute(SamplePluginConstants.ANNOTATION_KEY_MY_VALUE, arg0);