pinpoint-apm / pinpoint

APM, (Application Performance Management) tool for large-scale distributed systems.
https://pinpoint-apm.gitbook.io/
Apache License 2.0
13.39k stars 3.75k forks source link

pinpoint web inspector datasource does not display lines #10278

Open wenyiwener opened 1 year ago

wenyiwener commented 1 year ago

Prerequisites

Please check the FAQ, and search existing issues for similar questions before creating a new issue.YOU MAY DELETE THIS PREREQUISITES SECTION.

pinpoint 2.3.0 As shown in the figure, the table displays Active Max/Total Max/Active Avg values, but there are no lines in the line chart b8b154135f54208248bed23d5b5b7bf

minwoo-jung commented 1 year ago

@wenyiwener I'll review it with our frontend developer.

binDongKim commented 1 year ago

@wenyiwener Hi, let me ask you some questions to resolve the issue.

  1. Do you see any point on the chart when hovering up on it although there's no line? Like below: 스크린샷 2023-09-04 오후 2 26 20

  2. Can you provide the active avg data without other private metadata? Like just list of numbers. I'm suspecting something but it would be much clearer if you provide one.

Thank you.

wenyiwener commented 1 year ago

Hi, binDongKim Regarding your two questions, please reply as follows 1.There is indeed a point on the chart when hovering up on it ,as shown in the figure 0ba3621a488e5b529be414207918b1a

  1. JSON[0].charts.y.ACTIVE_CONNECTION_SIZE [ [ 0, 0, 0, 0 ], [ -1, -1, -1, -1 ], [ -1, -1, -1, -1 ], [ -1, -1, -1, -1 ], [ -1, -1, -1, -1 ], [ -1, -1, -1, -1 ], [ 8, 8, 8, 8 ], [ -1, -1, -1, -1 ], [ -1, -1, -1, -1 ], [ -1, -1, -1, -1 ], [ -1, -1, -1, -1 ], [ -1, -1, -1, -1 ], [ 9, 9, 9, 9 ], [ -1, -1, -1, -1 ], [ -1, -1, -1, -1 ], [ -1, -1, -1, -1 ], [ -1, -1, -1, -1 ], [ -1, -1, -1, -1 ], [ 0, 0, 0, 0 ], [ -1, -1, -1, -1 ], [ -1, -1, -1, -1 ], [ -1, -1, -1, -1 ], [ -1, -1, -1, -1 ], [ -1, -1, -1, -1 ], [ 0, 0, 0, 0 ], [ -1, -1, -1, -1 ], [ -1, -1, -1, -1 ], [ -1, -1, -1, -1 ], [ -1, -1, -1, -1 ], [ -1, -1, -1, -1 ], [ 0, 0, 0, 0 ], [ -1, -1, -1, -1 ], [ -1, -1, -1, -1 ], [ -1, -1, -1, -1 ], [ -1, -1, -1, -1 ], [ -1, -1, -1, -1 ], [ 0, 0, 0, 0 ], [ 0, 0, 0, 0 ], [ -1, -1, -1, -1 ], [ -1, -1, -1, -1 ], [ -1, -1, -1, -1 ], [ -1, -1, -1, -1 ], [ 0, 0, 0, 0 ], [ -1, -1, -1, -1 ], [ -1, -1, -1, -1 ], [ -1, -1, -1, -1 ], [ -1, -1, -1, -1 ], [ -1, -1, -1, -1 ], [ 0, 0, 0, 0 ], [ -1, -1, -1, -1 ], [ -1, -1, -1, -1 ], [ -1, -1, -1, -1 ], [ -1, -1, -1, -1 ], [ -1, -1, -1, -1 ], [ 0, 0, 0, 0 ], [ -1, -1, -1, -1 ], [ -1, -1, -1, -1 ], [ -1, -1, -1, -1 ], [ -1, -1, -1, -1 ], [ -1, -1, -1, -1 ], [ 0, 0, 0, 0 ] ]
binDongKim commented 1 year ago

Thanks for your information. Let me walk you through the issue in detail.

The chart is actually rendering all the "valid" data you pass. But the reason it doesn't seem to display anything is because of the chart configuration and the data , especially the -1.

The -1 indicates no data was collected at that time and we determined to not display anything in the chart with -1. And I set the point radius to 0 in default and tell it to become visible(with r = 3) when the user hovers the actual(valid) data.

So with this config, when you hover the valid data, you should be able to see the points. In your case, since there are many -1, the chart is likely to be displayed empty although there are some data rendered in it.

I'm attaching an example with the similar config. https://stackblitz.com/edit/54cdfb?file=index.ts

I understand it could confuse the user and we will look into the better ui/ux about the issue. Thank you.

wenyiwener commented 1 year ago

I understand the reason and thank you very much for your answer