pinpox / base16-universal-manager

A universal manager to set base16 themes for any supported application

https://github.com/chriskempson/base16

MIT License

89 stars 20 forks source link

Various imrpovements - replace mode, specifing exact config location … #34

Closed nvlbg closed 4 years ago

nvlbg commented 4 years ago

…and more

List of changes introduces:

config structure is changed a bit to support the use case of specifing exact path of file and replace mode markers. This can be considered a breaking change and that's why I bumped the version as well (semantic versioning).
updated the README with the introduced changes from user perspective
implemented replace mode where only part of a file is replaced instead of rewriting the entire file
implemented expanding of ~ for user's home directory
removed code for append mode - in my opinion this is a useless mode since the operation is not idempotent. The same result should be achievable with replace mode.
refactored some of the code with improved error handling
added testdata/output* files in .gitignore - these files are used only temporary during test execution and don't need to be tracked

nvlbg commented 4 years ago

Hi! First of all, great project. It's the closest thing I could find for my base16 needs. However there is some missing functionality that I need and looking through the issues I can see that other people have stumbled upon the same things.

This pull request should close #16 #29 and #33

codecov[bot] commented 4 years ago

Codecov Report

Merging #34 into master will increase coverage by 5.58%. The diff coverage is 32.67%.

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage   12.46%   18.05%   +5.58%     
==========================================
  Files           5        5              
  Lines         353      421      +68     
==========================================
+ Hits           44       76      +32     
- Misses        302      324      +22     
- Partials        7       21      +14

Impacted Files	Coverage Δ
main.go	`0.95% <0.00%> (-0.35%)`	:arrow_down:
helpers.go	`41.79% <57.14%> (+17.05%)`	:arrow_up:
config.go	`42.42% <100.00%> (-1.70%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c9b6b43...4b76f99. Read the comment docs.

pinpox commented 4 years ago

Thanks for the PR and sorry for the delay merging!

I'm a bit busy at the moment, but PRs are very welcome