search

pinpox / base16-universal-manager

A universal manager to set base16 themes for any supported application
https://github.com/chriskempson/base16
MIT License
89 stars 20 forks source link

Fix tests and downloads from GitHub #47

Closed weslem closed 3 years ago

weslem commented 3 years ago

GitHub appears to now return a 404 when no GithubToken is specified. Instead of failing to retrieve and having empty templates or repo lists, return an error message to the user by propagating the HTTP error code.

weslem commented 3 years ago

Since my Travis CI run failed, I've added a commit to fix the already-broken tests.

I've also added a commit to permit ".yml" file extensions on schemes. At least one scheme is written that way.

codecov[bot] commented 3 years ago

Codecov Report

Merging #47 (5aee6e9) into master (a03047d) will decrease coverage by 2.82%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
- Coverage   17.75%   14.93%   -2.83%     
==========================================
  Files           5        5              
  Lines         428      395      -33     
==========================================
- Hits           76       59      -17     
+ Misses        331      317      -14     
+ Partials       21       19       -2
Impacted Files Coverage Δ
config.go 44.82% <ø> (+2.40%) :arrow_up:
helpers.go 33.33% <0.00%> (-8.46%) :arrow_down:
main.go 0.00% <0.00%> (-0.92%) :arrow_down:
colorscheme.go 4.30% <0.00%> (-0.51%) :arrow_down:
template.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 641180e...5aee6e9. Read the comment docs.

pinpox commented 3 years ago

Thanks, great work!