search

pinpox / base16-universal-manager

A universal manager to set base16 themes for any supported application
https://github.com/chriskempson/base16
MIT License
89 stars 20 forks source link

feature: local color schemes #61

Closed Phytolizer closed 1 year ago

Phytolizer commented 1 year ago

I saw there was a prior PR merged and reverted for this feature. But I'd still like to have it. I tested this with local and remote files. It seems to work :)

pinpox commented 1 year ago

Hm, I don't remember why it was reverted, it was breaking something. If you tested it, let's see if it works now.

Phytolizer commented 1 year ago

The issue with the old PR was that it was a too-simple change. It outright replaced the entire lookup mechanism with one that only searched local files. My version of the change follows what had been documented in the README for that change -- it only uses file-based lookup when the argument string contains a path separator.

pinpox commented 1 year ago

Thanks for the explanation!