search

pinsdorf / MMM-WeeklySchedule

Module for MagicMirror which shows a weekly timetable. Might be helpful for students/teachers/parents to show class schedules, weekly gym courses, sports training sessions, and general weekly recurring events.
MIT License
65 stars 26 forks source link

Hide during empty days? #3

Open Jacobphilli opened 6 years ago

Jacobphilli commented 6 years ago

Great module you've made here; there is a lot of use for it. But I was wondering if there is any native, or recommended, way for hiding the module during days that don't have any "lessons"?

The schedule modular that also seems popular only specifies time of day. But I'd like to have your module hidden three days a week, and displayed four days a week (the days that have something included).

Any advice is appreciated. Great work!

pinsdorf commented 6 years ago

Thanks for the nice feedback. Much appreciated!

If there is no lesson for a particular day then the module shows "No lessons today". The text appears when there is no weekday entry in the lessons array. For instance, the first example in the README.md file has no "sat" (Saturday) item defined.

Does this solve your problem or do you want to hide the module completely? In this case I could extend it with a config "hideOnNoLessonsDays" or similar.

I'm opening a separate issue for the wrong behavior of "showWeekdayinHeader".

Jacobphilli commented 6 years ago

Thanks for getting back. I think if there was a “hideOnNoLessonDays” (false/true) in the configuration for the entire module to be hidden, that would be a worthwhile addition.

If you have the time and feel inclined to do that.

retroflex commented 6 years ago

+1 for this one. To clarify my problem, it is that the header is always shown even when there is no schedule for that day. If the whole module can't be hidden, I guess it would be ok to just hide the header (not sure of how the MM API looks).

Great module btw!