pintariching / railwind

Tailwind compiler rewritten in rust
MIT License
317 stars 9 forks source link

Help with implementing classes #2

Closed pintariching closed 1 year ago

pintariching commented 1 year ago

Using the currently implemented classes as a example, I would need help to speed up the process of implementing the rest of tailwinds classes.

vermutely commented 1 year ago

I am new to Rust and would like to support this project. I am checking out the past commits right now. I would like to help add a class, are there any rules?

pintariching commented 1 year ago

Hey! No I don't have any special rules just choose a class that hasn't been yet implemented and look copy the implementation of other classes.

For classes that have to support theme customization, I load the values from a .ron file into a HashMap so it can later be extended with custom values.

Also if you want, you can also add more test cases, I think I'm not covering all the implemented classes yet. For that, I copy all the classes into play.tailwind.com and copy the output into an expected.css and the input into input.html and compare the output.css with the expected and see what should be changed.

vermutely commented 1 year ago

@pintariching Thanks for confirming! I will try to implement Transforms. I will create a pull request once the implementation is finished. I'll try to challenge you on the test code, etc., so please be patient!

pintariching commented 1 year ago

No worries, you can also open a half completed pull request and I can guide you how I've implemented stuff if you need help!

vermutely commented 1 year ago

@pintariching I have created a pull request for Transforms( #5 ). I will go into the implementation of Transitions & Animations next.

pintariching commented 1 year ago

@vermutely Thanks! I'll add the tests and see if everything works.

vermutely commented 1 year ago

@pintariching Thanks all for the lighting fast response! I'm thinking of implementing Filters and Tables next, does the work conflict?

pintariching commented 1 year ago

@vermutely No currently I'm not working on anything, feel free to open a PR

vermutely commented 1 year ago

@pintariching Thanks for confirming.

I will gradually increase my class support. I will try to write to this Issue before I start working on other classes so that others can also help.

vermutely commented 1 year ago

I have submitted a pull request for Tables and Filters, so the next step is to implement Interactivity.

vermutely commented 1 year ago

I have submitted a pull request for Interactivity. SVG and Accessibility next.

vermutely commented 1 year ago

I have submitted a pull request for SVG and Accessibility. (Thank you review!!)
Is this tasks complete?

pintariching commented 1 year ago

Wow, I didn't expect it to be done this quickly, thank you for everything @vermutely !

Now there's a few tasks of the top of my head that can be done at once I think.

I'll open a new issue with everything listed later today