pintariching / railwind

Tailwind compiler rewritten in rust
MIT License
317 stars 9 forks source link

Use Self where possible #37

Closed adamnemecek closed 1 year ago

pintariching commented 1 year ago

Is there any benefit to using Self instead of the struct name? Or is it just a matter of convention?

Also the same question for vec![] vs Vec::new().

adamnemecek commented 1 year ago

It's more idiomatic. Also you already use Self:: instead of the struct name in several places so this unifies it.

pintariching commented 1 year ago

The changes seem to make the build fail. Can you check it out?

adamnemecek commented 1 year ago

Done.