Added SPM support - Githubissues

3a4oT commented 3 years ago

Added SPM support starting from Swift 5.3 (since it supports resources). Some notes:

SPM tests not passing when you run it from a command line (SPM(bug)? gets the wrong bundle path) but passing if you use Xcode in SPM edit mode(just open as a package instead of .xcodeproj).
dependency strategy for PINOperation set as - branch master. I believe it should be set - from PINOperation 1.2.0 but unfortunately, it was tagged as 1.2 and SPM can not resolve it. Can the maintainers re-tag/new it with proper sem-ver?

xezero commented 3 years ago

This would be fantastic if this got merged! :)

3a4oT commented 3 years ago

@garrettmoon ping...

3a4oT commented 3 years ago

@garrettmoon, I've addressed your feedback. Thanks!

3a4oT commented 3 years ago

@garrettmoon This seems to be a sporadic failure, I can confirm that from time to time the same test fails locally. Can we trigger tests again?

pinterest / PINCache