search

pinterest / PINCache

Fast, non-deadlocking parallel object cache for iOS, tvOS and OS X
Apache License 2.0
2.66k stars 361 forks source link

Remove Carthage folder #306

Closed AYastrebov closed 4 weeks ago

AYastrebov commented 3 years ago

There is no need to store Carthage folder in repository.

Carthage is smart enought to symlink dependencies

garrettmoon commented 3 years ago

The way the project is currently setup it required (see the failure in the test and analyze steps on PINOperationQueue.h)

AYastrebov commented 3 years ago

The way the project is currently setup it required (see the failure in the test and analyze steps on PINOperationQueue.h)

I believe that CI should make carthage checkout before build and that should fix it

AYastrebov commented 3 years ago

@garrettmoon can you please launch workflows on CI?

AYastrebov commented 1 year ago

@garrettmoon can we merge it?