search

pinterest / PINOperation

Apache License 2.0
103 stars 49 forks source link

Fix group can add operations and set completion multiple times when the group start. #22

Open kinarobin opened 5 years ago

kinarobin commented 5 years ago

Thanks for pinterest contribution to open source!

And I found a _start flag that never used, So I hope to remove it.

garrettmoon commented 5 years ago

Ah! I think you've actually found a bug! I think _started should be set to YES when the group starts, otherwise it can be run multiple times!

kinarobin commented 5 years ago

Once the group start, the _operations = nil is executing. So it not run multiple times. But when the group start, it still can add operations and set completion, It was a bug. I will change the code.

garrettmoon commented 1 year ago

I'm so sorry this never got merged :( Any chance you can rebase it?