Swift Package Manager support

pinterest / PINOperation

Apache License 2.0

103 stars 49 forks source link

Swift Package Manager support #32

Closed martinpucik closed 4 years ago

martinpucik commented 4 years ago

Changes

Added Package.swift to support Swift Package Manager without changes to project structure, so hopefully nothing will break for Cocoapods and Carthage
Changed imports in public header file

Additional info

build, tests, analyze and pod lib lint were all green on my local machine, lets wait for CI and see if everything works

Kaspik commented 4 years ago

@garrettmoon / @jparise Hey! I know it might not be top priority, but we would love to use whole PINRemoteImage in module (framework) through SPM so we are ready to prepare it for SPM for you.

Martin started here, will continue with PINCache etc., but it would be nice if you could review this and stay up-to-date with our PRs and keep merging them if you think this is a good idea.

Thanks!

jparise commented 4 years ago

What sort of CI-level check should we have in place to verify that the packaging is (and remains) correct?

martinpucik commented 4 years ago

Hey @jparise thank you for taking a look at this!

I added a test target to SPM to run current tests in the package too, that should help verify it's behaving properly.

And I added an Example project and build step on CI where we can verify the Cocoapods integration is still working properly after adding SPM and making changes to PINOperation source.

Let me please know if you think any other checks or changes are necessary

Kaspik commented 4 years ago

@garrettmoon Thanks for merge! Would you mind bumping version and releasing new one + tag to make this available for PINCache and other parts as SPM already?

jparise commented 4 years ago

@Kaspik I think we'd be in a good place to release a new version once #31 is also addressed. That would give us good overall platform and packaging support.

Kaspik commented 4 years ago

@jparise https://github.com/pinterest/PINOperation/pull/31 merged as well, do you think we could release and tag new version for this? We would like to continue with SPM for PINCache and PINRemoteImage. :)

garrettmoon commented 4 years ago

Thank you both so much for the work! I'll get out a new release.

garrettmoon commented 4 years ago

Published!