Removes the optimization to reduce the display links frame interval

pinterest / PINRemoteImage

A thread safe, performant, feature rich image fetcher

Apache License 2.0

4.01k stars 511 forks source link

Removes the optimization to reduce the display links frame interval #528

Open garrettmoon opened 5 years ago

garrettmoon commented 5 years ago

The idea behind this optimization was to reduce the number of calls the display link would need for animated images which didn't draw every frame. But this has resulted in frames being dropped in certain cases where frameInterval isn't respected (see https://i.pinimg.com/originals/58/9c/e8/589ce828d2ef0797da0e85b1c6d2f2b3.gif)

Since the the display link fire method continues if we detect we're at the same image index as before, let's just remove this optimization.

ghost commented 5 years ago

	1 Warning
:warning:	Any source code changes should have an entry in CHANGELOG.md or have #trivial in their title.

Generated by :no_entry_sign: Danger

ghost commented 5 years ago

🚫 CI failed with log

bolsinga commented 4 years ago

Is it possible to add a test covering this change?