Fixed spm integration on regular Xcode project

pinterest / PINRemoteImage

A thread safe, performant, feature rich image fetcher

Apache License 2.0

4.01k stars 511 forks source link

Fixed spm integration on regular Xcode project #586

Closed 3a4oT closed 3 years ago

3a4oT commented 4 years ago

without this change project itself can be built as spm package, but failed to do so when you integrate it as a dependency via Xcode.

3a4oT commented 4 years ago

Will appreciate a new release if possible :) There is a similar PR fo the https://github.com/pinterest/PINCache/pull/301 In general, spm/cocopods/xcode/carthage support is a little mind-blowing :) cc @garrettmoon

garrettmoon commented 4 years ago

Thanks for putting this up! I hate to ask, but would you mind updating the CI test to ensure that SPM works when integrating into a project?

3a4oT commented 4 years ago

Yes sir! Will add it to my list.

mthole commented 3 years ago

Can we get a release with this in it, please? @garrettmoon

Ektris commented 3 years ago

Going to ask as well, can we please get a release for these fixes? @garrettmoon