pinterest / PINRemoteImage

A thread safe, performant, feature rich image fetcher
Apache License 2.0
4.01k stars 511 forks source link

PINRemoteImageWeakTask memory leak #621

Open rounak opened 2 years ago

rounak commented 2 years ago

We're seeing some PINRemoteImageWeakTask leaks in the memory graph debugger. Looking at the PINRemoteImage code, we store this weak task using [NSURLProtocol setProperty: forKey: inRequest:] method. But we never seem to be removing this task through the corresponding removePropertyForKey method call.

Is this expected? Or is the leak due to some other issue?

Thanks!

Screen Shot 2022-06-08 at 3 50 17 PM