pinterest / api-quickstart

Code that makes it easy to get started with the Pinterest API.
Apache License 2.0
119 stars 44 forks source link

always provide query parameters to get_iterator #27

Closed davidchaiken closed 2 years ago

davidchaiken commented 2 years ago

Issue #26 has a request to implement query parameters more consistently. This pull request pushes down the query parameter implementation into ApiObject:get_iterator and uses the query parameters consistently for all calls to get_iterator. This change is implemented in both python and nodejs, with modifications and additions to unit tests as appropriate. I also did some manual testing to verify that the changes work end-to-end. The requester has verified that this implementation should satisfy the need for consistent implementation of query parameters.

This pull request also has a minor fix to the get_analytics.js script, which was missing an await in the case where a new access token needs to be fetched.