search

pinterest / arcanist-linters

A collection of custom Arcanist linters
Apache License 2.0
63 stars 45 forks source link

Arc crashes on ESLint parse errors #21

Closed michaelmwu closed 4 years ago

michaelmwu commented 4 years ago

ruleId comes out to be None for babel-eslint. I fixed by changing to $offense['ruleId'] || 'unknown'

https://github.com/pinterest/arcanist-linters/blob/24c6667187f941dbe39c38efd5961f0a09b17f1b/src/ESLintLinter.php#L166

jparise commented 4 years ago

Thanks, @michaelmwu! Would you mind submitting a Pull Request with your fix? Otherwise, I'll try to get to this myself some time soon.

michaelmwu commented 4 years ago

https://github.com/pinterest/arcanist-linters/pull/22

jparise commented 4 years ago

Thanks!