search

pinterest / arcanist-linters

A collection of custom Arcanist linters
Apache License 2.0
63 stars 45 forks source link

Add PrettierESLintLinter #4

Closed CrabDude closed 6 years ago

jparise commented 6 years ago

Could we instead adjust the relative priorities of these two linters so they always run in a predictable order?

CrabDude commented 6 years ago

This is good to go. Includes 2 edge case fixes:

  1. node not installed (now show install instructions instead of exception)
  2. PHP@<5.4 (Array literals [] not supported)

Includes 2 improvements:

  1. Minor README fix
  2. Better logging when wrong/no version of yarn installed