pinterest / arcanist-linters

A collection of custom Arcanist linters
Apache License 2.0
63 stars 45 forks source link

Fix ruleID being set to 'true' #45

Closed kuba-orlik closed 4 years ago

kuba-orlik commented 4 years ago

It caused an error while sending a diff:

ERR-CONDUIT-CORE: Parameter 'name' has invalid type. Expected type 'string', got type 'bool'. at [<arcanist>/src/conduit/ConduitFuture.php:66]

It was cause by this line of code:

$message->setName($offense['ruleId'] || 'unknown');

that set the rule name to true instead of the ruleID