pinterest / arcanist-linters

A collection of custom Arcanist linters
Apache License 2.0
62 stars 45 forks source link

Revise the thriftcheck error pattern #82

Closed jparise closed 2 years ago

jparise commented 2 years ago

More recent versions of thriftcheck use a more compliant GCC-style output format which includes a space before the "severity" group. This matches similar tools, like shellcheck.

https://github.com/pinterest/thriftcheck/pull/32

This change adjusts the handler's pattern to parse this format in a backwards-compatible way (even though backwards compatibility isn't critical long-term as thriftcheck itself is close to its 1.0 release).