Ignore EOL comment that causes max_line_length to be exceeded, except in max-line-length rule - Githubissues

pinterest / ktlint

An anti-bikeshedding Kotlin linter with built-in formatter

https://pinterest.github.io/ktlint/

MIT License

6.08k stars 504 forks source link

Ignore EOL comment that causes max_line_length to be exceeded, except in max-line-length rule #2516

Closed paul-dingemans closed 5 months ago

paul-dingemans commented 5 months ago

Description

Ignore EOL comment that causes max_line_length to be exceeded, except in max-line-length rule

Rules should not start wrapping code in case the max_line_length is exceeded because of the EOL comment. The developer should determine whether the EOL comment should be shortened, or be placed on a separate line instead of wrapping via autocorrect.

Closes #2450

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

[X] Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
[X] At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
[X] Tests are added
[X] KtLint format has been applied on source code itself and violations are fixed
[X] PR title is short and clear (it is used as description in the release changelog)
[X] PR description added (background information)

Documentation is updated. See difference between snapshot and release documentation

[ ] Snapshot documentation in case documentation is to be released together with a code change
[ ] Release documentation in case documentation is related to a released version of ktlint and has to be published as soon as the change is merged to master