Exclude EOL-comments when check whether max line length is exceeded in rules other than max-line-length - Githubissues

pinterest / ktlint

An anti-bikeshedding Kotlin linter with built-in formatter

https://pinterest.github.io/ktlint/

MIT License

6.19k stars 505 forks source link

Exclude EOL-comments when check whether max line length is exceeded in rules other than max-line-length #2565

Closed paul-dingemans closed 7 months ago

paul-dingemans commented 7 months ago

Description

Exclude EOL-comments when check whether max line length is exceeded in rules other than max-line-length

Follow up on #2450 / #2516:

fix exception in function-literal in case the literal block just contains an EOL-comment only
Change function dropTrailingComment to private (it was not yet exposed in a released version before)

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

[X] Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
[X] At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
[X] Tests are added
[X] KtLint format has been applied on source code itself and violations are fixed
[X] PR title is short and clear (it is used as description in the release changelog)
[X] PR description added (background information)

Documentation is updated. See difference between snapshot and release documentation

[ ] Snapshot documentation in case documentation is to be released together with a code change
[ ] Release documentation in case documentation is related to a released version of ktlint and has to be published as soon as the change is merged to master

paul-dingemans commented 7 months ago

Exclude from changelist as original PR (#2516) is in this same release