Imports which are only used in code blocks which are suppressed for ktlint should not be reported as unused as removal results in compilation errors.
Refactored the code so that a rule can be marked with interface IgnoreKtlintSuppressions to indicate that all suppression for this rule are to be ignored.
The former SuppressionLocator lambda and object SuppressionLocatorBuilder are now replaced with the class SuppressionLocator. Upon each check whether a ASTNode has to be suppressed, it is also determined whether it is needed to rebuild the suppression hints. This is only needed when the code that is represented by the AST has been changed.
The CodeFormatter no longer has to rebuild the suppression locator after autocorrect. This responsibility is now moved into the RuleExecutionContext and SuppressionLocator itself.
Closes #2696
Checklist
Before submitting the PR, please check following (checks which are not relevant may be ignored):
[ ] Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
[ ] At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
[ ] Tests are added
[ ] KtLint format has been applied on source code itself and violations are fixed
[ ] PR title is short and clear (it is used as description in the release changelog)
[ ] Snapshot documentation in case documentation is to be released together with a code change
[ ] Release documentation in case documentation is related to a released version of ktlint and has to be published as soon as the change is merged to master
Description
Imports which are only used in code blocks which are suppressed for ktlint should not be reported as unused as removal results in compilation errors.
Refactored the code so that a rule can be marked with interface
IgnoreKtlintSuppressionsto indicate that all suppression for this rule are to be ignored.The former SuppressionLocator lambda and object SuppressionLocatorBuilder are now replaced with the class SuppressionLocator. Upon each check whether a ASTNode has to be suppressed, it is also determined whether it is needed to rebuild the suppression hints. This is only needed when the code that is represented by the AST has been changed.
The CodeFormatter no longer has to rebuild the suppression locator after autocorrect. This responsibility is now moved into the RuleExecutionContext and SuppressionLocator itself.
Closes #2696
Checklist
Before submitting the PR, please check following (checks which are not relevant may be ignored):
Closes #<xxx>orFixes #<xxx>(replace<xxx>with issue number)Documentation is updated. See difference between snapshot and release documentation