pinterest / riffed

Provides idiomatic Elixir bindings for Apache Thrift
Apache License 2.0
308 stars 37 forks source link

Crash on client errors #22

Closed scohen closed 8 years ago

scohen commented 8 years ago

Our thrift clients accumulate processes when there is an error on the server, This PR should help alleviate that by closing the clients if they encounter an unexpected error.

@jparise @stemmler

scohen commented 8 years ago

@jparise, The underlying problem I'm trying to resolve is a bug in the thrift client that's fixed in 0.10 (whenever that comes out). This solves it at the wrong layer, though it's helpful if you're making a client for Elixir under 0.9.x. I'm not going to merge this unless people demand it.