Server.start_link accepts server options as arguments

pinterest / riffed

Provides idiomatic Elixir bindings for Apache Thrift

Apache License 2.0

308 stars 37 forks source link

Server.start_link accepts server options as arguments #27

Closed predrag-rakic closed 6 years ago

predrag-rakic commented 8 years ago

We needed this to be able to specify server port in run-time.

scohen commented 8 years ago

@predrag-rakic, can you please add a unit test for this?

predrag-rakic commented 8 years ago

I will, as soon as I get some time.

coveralls commented 7 years ago

Coverage remained the same at 96.68% when pulling a661a016462a27c1fb5a9ec44566c051feffc9ad on predrag-rakic:start_link_args into 4defc4593e75b187643f1f189df8f070dbcf878a on pinterest:master.

predrag-rakic commented 7 years ago

@scohen unit test added

coveralls commented 7 years ago

Coverage remained the same at 96.68% when pulling 2649730a34902b062f610fccd7b34d13b845438a on predrag-rakic:start_link_args into 4defc4593e75b187643f1f189df8f070dbcf878a on pinterest:master.

coveralls commented 7 years ago

Coverage remained the same at 96.68% when pulling 8db533e4b4a963a3021724f9608e37ee76c8ab47 on predrag-rakic:start_link_args into 4defc4593e75b187643f1f189df8f070dbcf878a on pinterest:master.

predrag-rakic commented 7 years ago

@scohen I made requested changes.