pinterest / riffed

Provides idiomatic Elixir bindings for Apache Thrift
Apache License 2.0
308 stars 37 forks source link

Support thrift master? #28

Closed fire closed 8 years ago

fire commented 8 years ago

Since the server I'm using requires the definition of:

Type "i8" has not been defined.

Can you check if Riffed works with thrift master?

Is there any other option I can take?

scohen commented 8 years ago

@fire, Thrift master is basically 0.10, we have a host of improvements that will take advantage of it on the this branch: https://github.com/pinterest/riffed/tree/rift_1_5_0. We're actively pushing the thrift community to release 0.10 asap.

Because of the improvements, Riffed works differently (and better) than the present version. You should check it out. I don't see any issue with :i8 specifically. Riffed falls back on what the Erlang version uses for types and it should "just work" in this case.

fire commented 8 years ago

After switching to rift_1_5_0, the riffed part just works!