Allow multiple clients - Githubissues

pinterest / riffed

Provides idiomatic Elixir bindings for Apache Thrift

Apache License 2.0

308 stars 37 forks source link

Allow multiple clients #32

Open binaryseed opened 8 years ago

binaryseed commented 8 years ago

I've adapted the Client to be able to start multiple GenServers. I didn't want to change the behavior of any of the other start_link functions, so there's a new function signature...

{:ok, pid} = SomeClient.start_link(thrift_client: thrift_client)

Also included is a test of this behavior, and fixes to a few Elixir 1.3 compiler warnings.

Thanks!

coveralls commented 8 years ago

Coverage decreased (-0.05%) to 96.694% when pulling 2d317e9cb8332cd3495cac17616385d7dc9dc579 on binaryseed:allow-multiple-clients into f4a46547c626238a5037e152cf4e99f6ed11a4b5 on pinterest:master.

coveralls commented 8 years ago

Coverage decreased (-0.07%) to 96.68% when pulling c6ec30d654c846dfdff197de63d8a472c722ca60 on binaryseed:allow-multiple-clients into f4a46547c626238a5037e152cf4e99f6ed11a4b5 on pinterest:master.