pinterest / riffed

Provides idiomatic Elixir bindings for Apache Thrift
Apache License 2.0
308 stars 37 forks source link

Exceptions crashing process and v_1_5_0 #38

Open fire opened 8 years ago

fire commented 8 years ago

In my program with riffed, exceptions crash. I want to forward them to my application instead of crashing.

https://gist.github.com/fire/de385f33a07ca6416ccbc42df8abbfa8 <- log

https://github.com/fire/snappyex/blob/master/lib/snappyex/protocol.ex#L18 <- Where the riffed client is called.

fire commented 7 years ago

icecreamcohen [7:17 PM]
if you have a remote call called ping, Client.ping will return {:ok, response} or {:error, {exception, Exception}} while ping! will return your response or raise the exception

We worked on a design on slack.