search

pinterest / riffed

Provides idiomatic Elixir bindings for Apache Thrift
Apache License 2.0
308 stars 37 forks source link

Added bang functions to client #43

Open scohen opened 7 years ago

scohen commented 7 years ago

The Elixir idiom is to have a function that ends with an exclamation point throw an exception, and an unadorned function return {:ok, response} or {:error, reason}. This PR changes Riffed to respoect that idiom. It is a breaking change, and will break all clients upgrading from any version of elixometer < 1.5

Addresses https://github.com/pinterest/riffed/issues/38 @jparise @fire

fire commented 7 years ago

Checks have failed? Weird. Looks.

fire commented 7 years ago

Will you be merging this in?