search

pinterest / slackminion

A python bot framework for slack
MIT License
22 stars 14 forks source link

Migrate to the new Slack SDK #52

Closed KevinHock closed 2 years ago

KevinHock commented 2 years ago

The Issue

Right now we only use the old Slack client: https://github.com/pinterest/slackminion/blob/0f77ba56dfd3b26c48f998b88fcdac02d430c36c/setup.py#L23

As Slack writes, "the slackclient project is in maintenance mode now and this slack_sdk is the successor"

Why someone would want the new SDK

There are differences in APIs, e.g. (old) https://github.com/slackapi/python-slack-sdk/blob/01c4292c6b8159e620334c8cb313ec634c8021aa/slack/web/client.py#L958-L960 vs. (new) https://github.com/slackapi/python-slack-sdk/blob/a58ab92cd7172b62331020b8740a9185993c8d6f/slack_sdk/web/client.py#L1815 you'll see as_user is only in the V3 of Slack SDK.