search

pinterest / snappass

Share passwords securely
MIT License
841 stars 248 forks source link

upload docker image to dockerhub / github registry #13

Open yongwen opened 8 years ago

yongwen commented 8 years ago

would be nice to create and upload the snappass docker image to dockerhub so the snappass server could be easily pulled and started, demo, etc.

samueldg commented 8 years ago

For now I created an automatic build on samueldg/snappass. However, the best solution to have someone with rights to the pinterest GitHub account link it with an account on the Docker hub, and do the same automated build setup to always have the latest and greatest image available. Also, using git tags for versions would allow having different tags for the Docker repository as well.

yongwen commented 8 years ago

Thanks @samueldg ! and Yes, I do plan to add the auto built image to Pinterest's docker hub account so make it a little bit "official".

nichochar commented 6 years ago

Progress on this, @yongwen ? Is it still something we're looking to do ?

terowz commented 6 years ago

yes +1 on this

samueldg commented 6 years ago

Bumping this to let you know there's probably interest out there: The unofficial image I have set up (samueldg/snappass) hit the 1K pulls mark recently.

yongwen commented 6 years ago

Super Nice!

On Tue, Sep 11, 2018, 2:46 PM Samuel Dion-Girardeau < notifications@github.com> wrote:

Bumping this to let you know there's probably interest out there: The unofficial image I have set up (samueldg/snappass https://hub.docker.com/r/samueldg/snappass/) hit the 1K pulls mark recently.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pinterest/snappass/issues/13#issuecomment-420436625, or mute the thread https://github.com/notifications/unsubscribe-auth/AAeQY3MmNyw4rwE7ZlvbtcMubpDRKJ02ks5uaC8qgaJpZM4JPRHt .

nichochar commented 6 years ago

@yongwen is it possible to upload this to a pinterest public docker organization? '

cc @jparise

Majed6 commented 5 years ago

Could you please upload an official image ? <3

jparise commented 5 years ago

We're planning on using GitHub's package registry for this once we get access to it.

yongwen commented 5 years ago

uploaded the latest docker image to https://github.com/pinterest/snappass/packages/20674 @jparise @Majed6 can you verify if you can pull the image: docker pull docker.pkg.github.com/pinterest/snappass/snappass:4acef097e8ad64933e53c17ca5f1144bacc4859f

Not very sure how the default docker pull permission is for public consumption, as it seems to require docker login. this is the help page for using github registry https://help.github.com/en/articles/configuring-docker-for-use-with-github-package-registry

jparise commented 5 years ago

Yes, it looks like GitHub's Docker registry requires authentication. Given that, we might be better off with a public image on Docker Hub.

yongwen commented 5 years ago

yeah looks like it. Maybe something we could give feedback to Github package team to support public docker registry for public repo.

s4ke commented 2 years ago

For anyone running into this issue that has their own registry, you can use this script to build the image:

#!/bin/bash

VERSION="1.6.0"
RELEASE="https://github.com/pinterest/snappass/archive/refs/tags/v$VERSION.tar.gz"
DOCKER_REPOSITORY="<your-repo>/snappass"
DOCKER_TAG="$VERSION"

set -e -u -x -o pipefail

rm -rf "snappass-$VERSION"

curl -L "$RELEASE" -o - | tar -zxf -

cd "snappass-$VERSION"

docker build -f Dockerfile -t $DOCKER_REPOSITORY:$VERSION .
docker push $DOCKER_REPOSITORY:$VERSION