search

pinterest / teletraan

Teletraan is Pinterest's deploy system.
Apache License 2.0
1.81k stars 250 forks source link

Use the script configuration variable DISABLE_BACKUP_INSTANCE_TYPES to control whether backup instance types are enabled or disabled #1712

Closed liyaqin1 closed 2 months ago

liyaqin1 commented 2 months ago

Additional improvements are still needed before we can roll this feature out to the production instance.

liyaqin1 commented 2 months ago

I tested this on dev1. When the variable is set to true, the feature is hidden on the UI.

Screenshot 2024-09-06 at 5 12 49 PM Screenshot 2024-09-06 at 5 14 09 PM
liyaqin1 commented 2 months ago

If I remove the variable from the script config, the feature reappears on the UI.

Screenshot 2024-09-06 at 5 17 14 PM Screenshot 2024-09-06 at 5 18 26 PM
liyaqin1 commented 2 months ago

Hi @osoriano , since there are still several improvements needed for the backup instance types feature, I don’t want to enable it on the production instance just yet. This PR allows us to disable the feature by setting a script configuration variable. Additionally, I will be out of office next Monday and Tuesday. If anyone needs to deploy the Teletraan UI to the production instance, please ensure that Rodimus deploys the latest commit first, before deploying the Teletraan UI. Also, make sure that this PR is merged and deployed. Thank you very much. By the way, I have already added this script config variable for the production Teletraan UI.

Screenshot 2024-09-06 at 5 21 42 PM