Return 404 if no current deploy exists

pinterest / teletraan

Teletraan is Pinterest's deploy system.

Apache License 2.0

1.81k stars 250 forks source link

Return 404 if no current deploy exists #1736

Closed tylerwowen closed 1 month ago

tylerwowen commented 1 month ago

The current implementation let getDeploySafely handle deployId being null and throws an exception that will eventually be mapped to 500. To improve the usability of this API, explicitly throw 404 if deployId is blank.