pinterest / thriftcheck

A linter for Thrift IDL files
Apache License 2.0
16 stars 9 forks source link

Only apply 'field.id.{negative,zero}' to explicit field IDs #50

Closed jparise closed 2 years ago

jparise commented 2 years ago

Auto-assigned field IDs start at zero and then go negative. If auto- assigned fields are intentionally used (i.e. no field.id.missing check), then it's not helpful to report additional errors about the range of the auto-assigned values.

These checks now only report errors for explicitly assigned field IDs.