search

pinterest / thriftcheck

A linter for Thrift IDL files
Apache License 2.0
16 stars 9 forks source link

Suggest adding support for a folder as a check parameter. #62

Closed Tiny-Box closed 1 year ago

Tiny-Box commented 1 year ago

Using a folder as a path is a very common scenario in various linters (as this avoids having to manually input multiple files). I noticed that in the current cmd/main.go file, there is no support for using a folder as a parameter. Although it is possible to check multiple files by running thriftchecker a.thrift b.thrift, this can still be cumbersome, especially when there are many Thrift files to check.

Perhaps adding a recursive traversal method could be a good way to solve this issue.

Since I am not sure about the various use cases for this project, I open an issue to discuss this further with the author.

jparise commented 1 year ago

Good idea! I'll take a pass at implementing this in the new few days.

Tiny-Box commented 1 year ago

oh, It's okay, I've already implemented this on my own local Dev branch, so I'll sort it out and raise a PR tonight.

jparise commented 1 year ago

Closed by #63 and #64.